Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump sha3 version #647

Open
yihau opened this issue Apr 8, 2024 · 4 comments
Open

chore: bump sha3 version #647

yihau opened this issue Apr 8, 2024 · 4 comments
Assignees
@samkim-crypto

Comments

@yihau
Copy link
Member

yihau commented Apr 8, 2024

Problem

discussed with Sam earlier and we all agree that we should bump sha3 to the latest but we will need to update code base for some API breaking changes 😢
@yihau yihau mentioned this issue Apr 8, 2024
Closed
@Xuanwo
Copy link

Xuanwo commented Apr 19, 2024 •
edited
Loading

Hi, @samkim-crypto, are you still on this issue? I'm interested to tackle this issue.

@samkim-crypto
Copy link

Yeah, it seems like to update sha3, we would need to bump curve25519-dalek to v4, which is on hold at the moment due to some breaking changes. You are welcome to tackle it if this is not the case though!

@Xuanwo
Copy link

Xuanwo commented Apr 21, 2024

Yeah, it seems like to update sha3, we would need to bump curve25519-dalek to v4

Got it, I will take a look.

@Xuanwo Xuanwo mentioned this issue Apr 21, 2024
Closed
@Xuanwo
Copy link

Xuanwo commented Apr 21, 2024

Hi, @samkim-crypto, I have submitted a PR #946 for this. Welcome to take a review, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samkim-crypto samkim-crypto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump curve25519-dalek to v4, sha3 to v0.10 Xuanwo/agave
3 participants
@Xuanwo @yihau @samkim-crypto