clean up shrink candidate stat #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
force-pushed
the
accounts-db/shrink_select_stat
branch
2 times, most recently
from
a60c0d8 to
77c31c7
Compare
brooksprumo
reviewed
Oct 1, 2024
accounts-db/src/accounts_db.rs
Outdated
Comment on lines
4653
to
4662
| datapoint_info!( | ||
| "shrink_select", | ||
| ("select_time_us", measure.as_us(), i64), | ||
| ("candidates_count", candidates_count, i64), | ||
| ("selected_count", shrink_slots.len(), i64), | ||
| ( | ||
| "deferred_to_next_round_count", | ||
| shrink_slots_next_batch.len(), | ||
| i64 | ||
| ) |
There was a problem hiding this comment.
Should these new datapoints go into ShrinkStats instead?
There was a problem hiding this comment.
Maybe not.
FWIK. ShrinkStats is more like an aggregated view from accounts-db's perspective, which aggregates all the calls to shrink and report a sum of the timing and other stats for all the shrink invocations per a period. While this datapoint is to report timing and stats from just one invocation of shrink, such as one shrink call from ABS. Thus, it can be thought of as a more detailed stats for handle_snapshot_requests-timing.shrink_time.
HaoranYi
force-pushed
the
accounts-db/shrink_select_stat
branch
from
77c31c7 to
f6bf5a2
Compare
|
I pushed another change to move the datapoint one level up to |
brooksprumo
approved these changes
Oct 1, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
rework shrink select stat Co-authored-by: HaoranYi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When selecting candidate storages for shrinking, it will be helpful to report
how many storages are selected to shrink, how many are deferred for next round,
and what's the total number of storages to begin with. This will help us to
tune the threshold of alive ratio for shrinking cut off.
The current metric is using a debug counter, seems to be obsolete and doesn't
provide the above info.
Summary of Changes
rework shrink select metrics - report select timing, selected count, deferred
count, and total count as datapoint_info.
Fixes #