Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Add github commands that would trigger specific actions #117

Closed
5 tasks
ksolana opened this issue May 2, 2023 · 3 comments
Closed
5 tasks

Add github commands that would trigger specific actions #117

ksolana opened this issue May 2, 2023 · 3 comments
Labels
ci-cd Related to ci, cd enhancement New feature or request good first issue Good for newcomers

Comments

@ksolana
Copy link
Collaborator

ksolana commented May 2, 2023

See how swift does it: https://github.com/apple/llvm-project does it. We could have commands to run lint, premerge checks etc.

  • @check-lint: run the linter (clippy + fmt).
  • @check-pre-merge: run all the pre-merge checks. Essentially run all the checks we run already. This is useful if we want to rerun all the checks without updating the patch.
  • @help
  • @format-code (formats the code and commits to the PR). We don't have to do this one. As long as we are failing the pre-merge check (which we are already) in case of formatting errors.
  • @rebase: Rebase the patch on top of main. This would also trigger all the tests upon successful rebase. I think github already has this feature but i'm not sure why it doesn't show up already. see: https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/
@ksolana ksolana added bug Something isn't working enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels May 2, 2023
@ksolana ksolana added the ci-cd Related to ci, cd label Aug 9, 2023
@yihau
Copy link
Member

yihau commented Aug 15, 2023

Just created a POC here: yihau#1. Does this do what we expect? (I use ! instead of @ to avoid at some wrong people accidentally. also only implement help and check-lint there)

btw, what's check-pre-merge for?

@yihau
Copy link
Member

yihau commented Sep 11, 2023

let me create these issues separately so that we can focus on single topic in each individual issue.

@yihau
Copy link
Member

yihau commented Sep 11, 2023

opened some issues and have some comments there. we can discuss there and close them as completed when we have PRs or other alternative methods to solve them

@ksolana ksolana closed this as completed Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd Related to ci, cd enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants