Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing scrolling issue mentioned in Issue #142 #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mghrabi
Copy link

@Mghrabi Mghrabi commented May 13, 2023

I approached the safer solution:

  • Made a border around the window screen to make it obvious that it's a screen

@Mghrabi
Copy link
Author

Mghrabi commented May 13, 2023

Fixes #142

There were many solutions I could think of, but I approached the safest solution that taking into consideration the future development of that feature, I simply drew a border line around that screen to make it obvious to users that it's a screen, not a normal white space. Solutions I thought of doing:

  1. I could have set the Height of the screen to auto and that should have solved the problem FOR NOW as the feature isn't already in use (from my understanding)

  2. I could have made a simple code checking if the number of elements is 0, and if so it should remove that white space (screen) till the number of elements becomes at least 1, then shows the screen. But this solution will edit the code structure a bit and could be against the future plans as this screen functionality is still not 100% clear to me.

@Mghrabi
Copy link
Author

Mghrabi commented May 13, 2023

How it looks after putting the borderline:

Screenshot (785)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant