From 5d48eda90c68ba89fb8e74fbee88ed9de63e3b22 Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 18 Dec 2024 18:17:06 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Andrew Lamb --- arrow-array/src/builder/generic_bytes_dictionary_builder.rs | 5 +++-- arrow-array/src/builder/primitive_dictionary_builder.rs | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arrow-array/src/builder/generic_bytes_dictionary_builder.rs b/arrow-array/src/builder/generic_bytes_dictionary_builder.rs index 4a661063ef94..ead151d5ceea 100644 --- a/arrow-array/src/builder/generic_bytes_dictionary_builder.rs +++ b/arrow-array/src/builder/generic_bytes_dictionary_builder.rs @@ -305,9 +305,10 @@ where }; } - /// Extends builder with dictionary + /// Extends builder with an existing dictionary array. /// - /// This is the same as `extends` but avoid lookup for each item in the iterator + /// This is the same as [`Self::extend`] but is faster as it translates + /// the dictionary values once rather than doing a lookup for each item in the iterator /// /// when dictionary values are null (the actual mapped values) the keys are null /// diff --git a/arrow-array/src/builder/primitive_dictionary_builder.rs b/arrow-array/src/builder/primitive_dictionary_builder.rs index 00498e46a1b1..282f0ae9d5b1 100644 --- a/arrow-array/src/builder/primitive_dictionary_builder.rs +++ b/arrow-array/src/builder/primitive_dictionary_builder.rs @@ -307,7 +307,8 @@ where /// Extends builder with dictionary /// - /// This is the same as `extends` but avoid lookup for each item in the iterator + /// This is the same as [`Self::extend`] but is faster as it translates + /// the dictionary values once rather than doing a lookup for each item in the iterator /// /// when dictionary values are null (the actual mapped values) the keys are null ///