Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object-store: could not find header in client for http feature #4775

Closed
kylebarron opened this issue Sep 5, 2023 · 1 comment · Fixed by #4796
Closed

object-store: could not find header in client for http feature #4775

kylebarron opened this issue Sep 5, 2023 · 1 comment · Fixed by #4796
Labels
bug object-store Object Store Interface

Comments

@kylebarron
Copy link
Contributor

Describe the bug

With object store set as a dependency using:

object_store = {version = "0.7.0", optional = true, features = ["http"]}

I'm getting

error[E0432]: unresolved import `crate::client::header`
  --> /Users/kyle/.cargo/registry/src/index.crates.io-6f17d22bba15001f/object_store-0.7.0/src/http/mod.rs:43:20
   |
43 | use crate::client::header::header_meta;
   |                    ^^^^^^ could not find `header` in `client`

error[E0433]: failed to resolve: could not find `header` in `client`
  --> /Users/kyle/.cargo/registry/src/index.crates.io-6f17d22bba15001f/object_store-0.7.0/src/http/mod.rs:66:32
   |
66 |         source: crate::client::header::Error,
   |                                ^^^^^^ could not find `header` in `client`

Specifically it looks like that mod is only built if one of aws, gcp, or azure are built.

#[cfg(any(feature = "aws", feature = "gcp", feature = "azure"))]
pub mod header;

To Reproduce

Check out this PR: kylebarron/parquet-wasm#311

> cargo build --features arrow1 --features async
error[E0432]: unresolved import `crate::client::header`
  --> /Users/kyle/.cargo/registry/src/index.crates.io-6f17d22bba15001f/object_store-0.7.0/src/http/mod.rs:43:20
   |
43 | use crate::client::header::header_meta;
   |                    ^^^^^^ could not find `header` in `client`

   Compiling snap v1.1.0
error[E0433]: failed to resolve: could not find `header` in `client`
  --> /Users/kyle/.cargo/registry/src/index.crates.io-6f17d22bba15001f/object_store-0.7.0/src/http/mod.rs:66:32
   |
66 |         source: crate::client::header::Error,
   |                                ^^^^^^ could not find `header` in `client`

Expected behavior

I'm trying to use object store in wasm, so I can use only the http feature.

Additional context

@kylebarron kylebarron added the bug label Sep 5, 2023
@kylebarron kylebarron changed the title object-store: Can't use http feature on its own object-store: `could not find header in client ` Sep 5, 2023
@kylebarron kylebarron changed the title object-store: `could not find header in client ` object-store: could not find header in client for http feature Sep 5, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 7, 2023
@tustvold tustvold added the object-store Object Store Interface label Sep 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from #4796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants