Add additional documentation for UTC representation of timestamps #6994
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdullahsab3
changed the title
alamb
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Thank you for the contribution @Abdullahsab3 . This change Makes sense to me.
I spetnt some time messing searching around in this repo and it does appear to use "+00:00" for UTC
https://github.com/search?q=repo%3Aapache%2Farrow-rs%20%22UTC%22&type=code
It also seems to be what is used by DataFusion mostly as well: https://github.com/search?q=repo%3Aapache%2Fdatafusion+%22UTC%22&type=code
💯
|
Seems as if there is one small CI failure |
|
I plan to merge this in the next few days -- I will leave it open a bit longer to give anyone else a chance to comment who might be interested. Thanks again @Abdullahsab3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
closes #6993
Rationale for this change
Additional documentation of what representation should be used for UTC
What changes are included in this PR?
Are there any user-facing changes?