Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatbuffers requirement from 24.12.23 to 25.1.24 #7032

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 27, 2025

Updates the requirements on flatbuffers to permit the latest version.

Release notes

Sourced from flatbuffers's releases.

v25.1.24

What's Changed

New Contributors

Full Changelog: google/flatbuffers@v25.1.21...v25.1.24

Changelog

Sourced from flatbuffers's changelog.

[25.1.24] (January 24 2024)(https://github.com/google/flatbuffers/releases/tag/v25.1.24))

  • Mostly related to bazel build support.
  • Min bazel supported is now 7 or higher, as WORKSPACE files are removed (#8509)
  • Minor C++ codegen fix removing extra semicolon (#8488)

[25.1.21] (January 21 2025)(https://github.com/google/flatbuffers/releases/tag/v25.1.21)

[24.3.25] (March 25 2024)(https://github.com/google/flatbuffers/releases/tag/v24.3.25)

  • Fixed license metadata parsing (#8253)
  • [C++] Allow string_view in LookUpByKey in addition to null-terminated c-style strings (#8203)

[24.3.7] (March 7 2024)(https://github.com/google/flatbuffers/releases/tag/v24.3.7)

  • Just to fix some of the CI build issues from the 24.3.6 release.

[24.3.6] (March 6 2024)(https://github.com/google/flatbuffers/releases/tag/v24.3.6)

  • Fix typescript object API to allow 0 values for null-default scalars (#7864)

23.5.26 (May 26 2023)

  • Mostly bug fixing for 64-bit support
  • Adds support for specifying underling type of unions in C++ and TS/JS (#7954)

23.5.9 (May 9 2023)

  • 64-bit support for C++ (#7935)

23.5.8 (May 8 2023)

  • add key_field to compiled tests
  • Add golden language directory
  • Rework cmake flatc codegeneration (#7938)
  • remove defining generated files in test srcs
  • Add binary schema reflection (#7932)
  • Migrate from rules_nodejs to rules_js/rules_ts (take 2) (#7928)
  • flat_buffers.dart: mark const variable finals for internal Dart linters
  • fixed some windows warnings (#7929)
  • inject no long for FBS generation to remove logs in flattests (#7926)
  • Revert "Migrate from rules_nodejs to rules_js/rules_ts (#7923)" (#7927)
  • Migrate from rules_nodejs to rules_js/rules_ts (#7923)
  • Only generate @​kotlin.ExperimentalUnsigned annotation on create*Vector methods having an unsigned array type parameter. (#7881)
  • additional check for absl::string_view availability (#7897)
  • Optionally generate Python type annotations (#7858)
  • Replace deprecated command with environment file (#7921)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [flatbuffers](https://github.com/google/flatbuffers) to permit the latest version.
- [Release notes](https://github.com/google/flatbuffers/releases)
- [Changelog](https://github.com/google/flatbuffers/blob/master/CHANGELOG.md)
- [Commits](google/flatbuffers@v24.12.23...v25.1.24)

---
updated-dependencies:
- dependency-name: flatbuffers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@alamb
Copy link
Contributor

alamb commented Jan 27, 2025

per @tustvold #7008 (comment)

Given flatbuffers is in our public API, I think this has to wait until the next major release

@alamb alamb added the next-major-release the PR has API changes and it waiting on the next major version label Jan 27, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs to wait to the next major release (or for someone to spend the time to figure out flatbuffers doesnt' get used in the arrow public API)

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2025

Superseded by #7118.

@dependabot dependabot bot closed this Feb 11, 2025
@dependabot dependabot bot deleted the dependabot/cargo/main/flatbuffers-25.1.24 branch February 11, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate auto-dependencies next-major-release the PR has API changes and it waiting on the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant