Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add LinkedIn social link and fix top nav scaling problems #45230

Closed
ianmcook opened this issue Jan 11, 2025 · 1 comment
Closed

[Docs] Add LinkedIn social link and fix top nav scaling problems #45230

ianmcook opened this issue Jan 11, 2025 · 1 comment

Comments

@ianmcook
Copy link
Member

ianmcook commented Jan 11, 2025

Describe the bug, including details regarding any error messages, version, and platform.

We should add a LinkedIn icon social link to the main docs pages. We created a Linkedin page for the project in mid-2024. It has been in active use since then. This month, we added a LinkedIn follow button to the website homepage. So it makes sense to add a LinkedIn icon social link to the main docs pages alongside the X icon social link.

However, this will increase the width of the contents in the top nav. As is, the layout of the top nav is already broken on smaller screens, with the items wrapping onto multiple lines at screen widths above 960px (which is the breakpoint at which the PyData Sphinx page layout changes and the top nav items move into a modal side nav) and below 1200px. So we should also fix this problem at the same time.

Component(s)

Documentation

@ianmcook ianmcook self-assigned this Jan 11, 2025
@ianmcook ianmcook added this to the 20.0.0 milestone Jan 11, 2025
ianmcook added a commit that referenced this issue Jan 13, 2025
…blems (#45228)

This adds a LinkedIn icon social link to the main docs pages and fixes the layout of the top nav, which previously looked bad
at widths between 960px and 1200px.

* GitHub Issue: #45230
@ianmcook ianmcook modified the milestones: 20.0.0, 19.0.1 Jan 23, 2025
@ianmcook
Copy link
Member Author

Resolved by #45228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant