GH-43985: [Python][C++] Fixed pyarrow table equality function not comparing table data when comparing against itself #44497
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Python
awaiting review
kou
reviewed
Oct 22, 2024
Comment on lines
+2304
to
+2306
| # With dicts containing NaNs | ||
| table = cls.from_pydict({"foo": [float("nan")]}) | ||
| assert table != table |
There was a problem hiding this comment.
Could you also add a C++ level test to detect this case only in C++ level?
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
pitrou
reviewed
Nov 18, 2024
| @@ -2301,6 +2301,10 @@ def test_table_from_pydict(cls): | |||
| with pytest.raises(TypeError): | |||
| cls.from_pydict({'a': [1, 2, 3]}, schema={}) | |||
|
|
|||
| # With dicts containing NaNs | |||
There was a problem hiding this comment.
This test isn't related to from_pydict, we should either make it a purely C++ test as @kou suggested, or add it to an equality related test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change is to address issue #43985 in which a bug in the behaviour of equality on pyarrow tables occurs when comparing a table containing a NaN value against itself.
What changes are included in this PR?
ifblock inarrow/cpp/src/arrow/table.ccthat forced a return true if memory address of the two items being compared were equal, no matter the data stored inside.Are these changes tested?
Yes. I put a test in the
arrow/python/pyarrow/tests/test_table.pyunder thetest_table_from_pydictfunction, as I wasn't sure and couldn't find where else to put the test.Are there any user-facing changes?
No
pyarrow.Tableequality comparison behavior is unexpected #43985