Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added-cpu-core-and-memory-range-fot-type-offers-CustomConstrained #9930

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LayonRibeiro
Copy link
Contributor

Description

This PR intends to enable the visualization of the amount of CPU/memory allocated in custom constrained compute offerings, which is currently not possible, thus improving the user experience.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

before

After

after

How Has This Been Tested?

The CPU/memory ranges appeared in the offerings table under Compute Offerings.

ui/src/components/view/ListView.vue Outdated Show resolved Hide resolved
ui/src/components/view/ListView.vue Outdated Show resolved Hide resolved
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (f7b7339) to head (e8e4779).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9930      +/-   ##
============================================
- Coverage     15.80%   15.80%   -0.01%     
  Complexity    12586    12586              
============================================
  Files          5627     5627              
  Lines        492294   492341      +47     
  Branches      62198    59693    -2505     
============================================
+ Hits          77824    77828       +4     
- Misses       405946   405990      +44     
+ Partials       8524     8523       -1     
Flag Coverage Δ
uitests 4.04% <ø> (-0.01%) ⬇️
unittests 16.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9930 (QA-JID-479)

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9930 (QA-JID-480)

Copy link
Collaborator

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified in qa

Before

image

After

image


Related, but not required for this PR: we could also include the CPU/memory range in the compute offering's info card

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants