Remove Insight & Disable telemetry #632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
CLI
Motivation and Context
closes #625
Insight is no longer maintained and it contains sub-dependencies with moderate vulnerabilities.
Description
All code relating to telemetry and using Insight have been commented out.
Fake implementations were left in place so our Telemetry API still exists, just it will
always "opt out" of telemetry.
This is done so that we can easily bring back telemetry later once we find a replacement for Insight.
Tests related to telemetry were disabled.
This PR is intended to be a stopgap just to resolve the present audit issues.
Testing
Ran
npm test
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)