Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated maturin version and ccargo build to build yml #1136

Merged
merged 21 commits into from
Nov 27, 2024

Conversation

tbar4
Copy link
Contributor

@tbar4 tbar4 commented Nov 25, 2024

Which issue does this PR close?

Closes #1135

Rationale for this change

This change will allow us to create python wheel files for several different platforms.

What changes are included in this PR?

A github build file for python wheels will be added and we will also be updating maturin from 0.6.0 t0 1.6.0

Are there any user-facing changes?

There are no user facing changes

@tbar4
Copy link
Contributor Author

tbar4 commented Nov 26, 2024

@andygrove I will tried to get the rest of the jobs fixed tomorrow.

@tbar4
Copy link
Contributor Author

tbar4 commented Nov 27, 2024

@andygrove checks passed, had to remove maturin github action and manually implement because it couldn't resolve protoc because it is not available in the maturin action

@tbar4
Copy link
Contributor Author

tbar4 commented Nov 27, 2024

@andygrove @milenkovicm update python requirement to align with #1141 of python >=3.7

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tbar4! Much appreciated.

@andygrove andygrove merged commit 81cfa63 into apache:main Nov 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Issue with maturin Cargo.lock file
2 participants