Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to limit number of executor worker threads #1139

Closed
wants to merge 2 commits into from

Conversation

milenkovicm
Copy link
Contributor

@milenkovicm milenkovicm commented Nov 26, 2024

executor_cores configuration option is similar to spark.executor.cores, it sets number of tokio worker threads limiting executor cpu utilisation.

Which issue does this PR close?

Closes none .

Rationale for this change

provide ability to users to limit number of cores which executor can utilise limiting overall resource utilisation

What changes are included in this PR?

  • new configuration option
  • tokio executors got their own name

Are there any user-facing changes?

new configuration option exposed to user

@milenkovicm
Copy link
Contributor Author

there is also concurrent_tasks which configuration option, i believe if executor_cores is set it concurrent_tasks should be <= to executor_cores

@milenkovicm
Copy link
Contributor Author

will open another PR to remove cache_ executor config options

this option is similar to `spark.executor.cores`
it sets number of tokio worker threads.
@milenkovicm
Copy link
Contributor Author

this PR may make no sense as there is dedicated executor which has limited number of runners

@milenkovicm milenkovicm marked this pull request as draft November 27, 2024 10:21
@milenkovicm
Copy link
Contributor Author

DedicatedExecutor will limit number of threads based on concurrent_tasks, maybe we should document it better. Closing this task, apologies for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant