Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unsafe code with miri #1161

Closed
andygrove opened this issue Dec 11, 2024 · 1 comment
Closed

Test unsafe code with miri #1161

andygrove opened this issue Dec 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

As part of upgrading to DataFusion 44.0.0 (PR), we had to stop running our test suite with miri. This means that we risk introducing undefined behavior when we add or modify unsafe code in Comet.

Describe the potential solution

We should enable miri for specific test suites that test our unsafe code.

Additional context

No response

@andygrove
Copy link
Member Author

This is no longer required, because we were able to resolve the issue in 44 that originally was going to cause us to disable miri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant