Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted rows returned by DataFusion sort operator could be in different order than Spark on irrelevant columns #629

Closed
viirya opened this issue Jul 5, 2024 · 0 comments · Fixed by #628
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Jul 5, 2024

What is the problem the feature request solves?

During debugging incorrect TPCDS queries in #613, these incorrect rows are not ordered as Spark.

I found that the order of returned rows are not related to the sorting columns. For example, if you sort on [a, b], there are some rows with same [a, b] so the order of these rows are irrelevant to the sorting order, i.e., either

|a|b|c|
|0|1|1|
|0|1|2|

or

|a|b|c|
|0|1|2|
|0|1|1|

are correct results for sorting on [a, b]. In these failed queries, Spark sort produces one and DataFusion sort produces another one. Because we compare the results as string, they are considered incorrect now by CometTPCDSQuerySuite.

Describe the potential solution

No response

Additional context

No response

@viirya viirya added the enhancement New feature or request label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant