Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ScalarFunctionDefinition #10175

Closed
Omega359 opened this issue Apr 22, 2024 · 0 comments · Fixed by #10325
Closed

Remove ScalarFunctionDefinition #10175

Omega359 opened this issue Apr 22, 2024 · 0 comments · Fixed by #10325
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

As noted in #10098 (comment) The ScalarFunctionDefinition::Name is seemingly unused which means that ScalarFunctionDefinition is essentially a simple wrapper to Arc<crate::ScalarUDF> and thus may be a candidate for removal. This would simplify the code slightly and remove a number of code blocks such as

ScalarFunctionDefinition::Name(_) => {
    internal_err!("Function `Expr` with name should be resolved.")
}

Describe the solution you'd like

ScalaraFunctionDefinition is removed and all code references updated.

Describe alternatives you've considered

Leave the code as is. Or possibly just remove the ScalarFunctionDefinition::Name(_) enum

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant