Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all remaining failures in sqlite tests #13972

Closed
Tracked by #13811
Omega359 opened this issue Jan 1, 2025 · 2 comments
Closed
Tracked by #13811

Validate all remaining failures in sqlite tests #13972

Omega359 opened this issue Jan 1, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Omega359 commented Jan 1, 2025

Is your feature request related to a problem or challenge?

Now that the sqlite test have been merged (#13936) the remaining failures in the tests must be looked at manually and either:

  • marked as skipif Datafusion with an explanation (sql is nonstandard/invalid/etc)
  • marked as skipIf Datafusion with a link to an existing issue
  • a new ticket created and the corresponding failures marked with a link to the new issue and a skipif Datafusion line added.

For examples of how to add this to the .slt files in datafusion-testing search for skipif Datafusion in those files.

Fixes/changes will need to have a PR created in the datafusion-testing repo and merged in before it will be visible to CI/etc in datafusion.

I do not have an exact count of the number of failures as the sqllogictest is fail-fast however I expect it to be in the low hundreds with many of those being variations on existing issues.

Describe the solution you'd like

At the end of this process running the sqlite test suite (INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests) should result in no failures.

Describe alternatives you've considered

No response

Additional context

No response

@Omega359
Copy link
Contributor Author

Omega359 commented Jan 1, 2025

Epic this ticket is under: #13811

@Omega359
Copy link
Contributor Author

The tests now run to completion in CI. That means this ticket can be closed however there still are outstanding issues with the tests that should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant