You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge?
As part of the review for #13953@2010YOUY01 brought up that some of the error handling code in datafusion/physical-expr/src/expressions/case.rs can be simplified, due to type checks being performed before evaluation.
This will clean-up and simplify the code a little bit.
Describe the solution you'd like
Replace occurences similar to
DataFusionError::Context("WHEN expression did not return a BooleanArray".to_string(),Box::new(e),)
and
let expr = try_cast(Arc::clone(e),&batch.schema(), return_type.clone()).unwrap_or_else(|_| Arc::clone(e));
I think this is a nice issue for someone who wants to clean up the code and learn how DataFusion works but doesn't require detailed internals understanding
Is your feature request related to a problem or challenge?
As part of the review for #13953 @2010YOUY01 brought up that some of the error handling code in
datafusion/physical-expr/src/expressions/case.rs
can be simplified, due to type checks being performed before evaluation.This will clean-up and simplify the code a little bit.
Describe the solution you'd like
Replace occurences similar to
and
with code that returns an internal error directly
Describe alternatives you've considered
No response
Additional context
Link to suggestions from the review:
The text was updated successfully, but these errors were encountered: