Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqllogictest statement error no escaping #6258

Closed
aprimadi opened this issue May 6, 2023 · 4 comments
Closed

sqllogictest statement error no escaping #6258

aprimadi opened this issue May 6, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@aprimadi
Copy link
Contributor

aprimadi commented May 6, 2023

Is your feature request related to a problem or challenge?

Currently ( and ) character needs to be escaped in sqllogictest statement error. Not sure if this is possible but it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.

Expected

statement error ParserError("blablabla")

Current

statement error ParserError\("blablabla"\)

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@aprimadi aprimadi added the enhancement New feature or request label May 6, 2023
@alamb
Copy link
Contributor

alamb commented May 19, 2023

FYI @melgenek -- this seems very similar to #5727

I wonder if we can apply a similar fix 🤔

@melgenek
Copy link
Contributor

it would be great if I can just supply a string that is an exact match of the output and not need to escape the character.

If I understand correctly, there is no issue at the moment, and validation works correctly when symbols are escaped.

sqllogictest-rs makes an explicit choice to have errors as Regexp, that's why there is a need to escape characters that have special meaning in Regex like (,),.,[,]

@alamb
Copy link
Contributor

alamb commented May 19, 2023

I think I have seen errors (maybe where newlines aren't escaped?) I'll pay attention to this in more detail if it happens again

@alamb
Copy link
Contributor

alamb commented May 19, 2023

Closing this ticket as working as expected, I think

@alamb alamb closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants