Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate code duplication between math UDFs #9552

Closed
jonahgao opened this issue Mar 11, 2024 · 2 comments · Fixed by #9598
Closed

Eliminate code duplication between math UDFs #9552

jonahgao opened this issue Mar 11, 2024 · 2 comments · Fixed by #9598
Assignees
@jonahgao
Labels
enhancement New feature or request

Comments

@jonahgao
Copy link
Member

jonahgao commented Mar 11, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

The codes in acos.rs, asin.rs under the new functionn packege and codes in #9535 are quite similar.
Perhaps they could be simplified with the help of a common macro.

Describe the solution you'd like

A common macro similar to math_unary_function, used to define math UDFs.

Describe alternatives you've considered

No response

Additional context

No response
@jonahgao jonahgao added the enhancement New feature or request label Mar 11, 2024
@alamb
Copy link
Contributor

alamb commented Mar 11, 2024

Thank you @jonahgao -- I agree this would be very helpful

@jonahgao
Copy link
Member Author

take

@jonahgao jonahgao mentioned this issue Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahgao jonahgao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use a common macro to define math UDFs jonahgao/datafusion
2 participants
@alamb @jonahgao