Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_timestamp benchmark doesn't actually run the test #9607

Closed
Omega359 opened this issue Mar 14, 2024 · 2 comments · Fixed by #9608
Closed

to_timestamp benchmark doesn't actually run the test #9607

Omega359 opened this issue Mar 14, 2024 · 2 comments · Fixed by #9608
Assignees
@Omega359
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Describe the bug

the benchmark just calls the to_timestamp function but doesn't actually execute it. It needs to call the correct to_timestamp function with .invoke(...) calls.

To Reproduce

Run to_timestamp benchmark. The results are far too good

Expected behavior

No response

Additional context

No response
@Omega359 Omega359 added the bug Something isn't working label Mar 14, 2024
@Omega359
Copy link
Contributor Author

take

@Omega359 Omega359 mentioned this issue Mar 14, 2024
Merged
@alamb
Copy link
Contributor

alamb commented Mar 14, 2024

Related conversation: #9601 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omega359 Omega359

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to_timestamp benchmark Omega359/arrow-datafusion
2 participants
@Omega359 @alamb