-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]downgrade resource tag when there is not queryable replica #44255
Open
wangbo
wants to merge
2
commits into
apache:master
Choose a base branch
from
wangbo:1118_skip_bad_replica
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+269
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
wangbo
force-pushed
the
1118_skip_bad_replica
branch
from
November 19, 2024 07:13
fcf5599
to
ae741b9
Compare
run buildall |
TPC-H: Total hot run time: 44590 ms
|
wangbo
force-pushed
the
1118_skip_bad_replica
branch
from
November 20, 2024 11:38
ae741b9
to
6f61ec8
Compare
wangbo
changed the title
[Improvement]skip resource tag when there is not queryable replica
[Improvement]downgrade resource tag when there is not queryable replica
Nov 20, 2024
run buildall |
TPC-H: Total hot run time: 40148 ms
|
TPC-DS: Total hot run time: 192334 ms
|
ClickBench: Total hot run time: 33.08 s
|
run buildall |
TPC-H: Total hot run time: 40426 ms
|
TPC-DS: Total hot run time: 192278 ms
|
ClickBench: Total hot run time: 32.69 s
|
yiguolei
reviewed
Nov 25, 2024
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java
Outdated
Show resolved
Hide resolved
yiguolei
reviewed
Nov 25, 2024
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java
Outdated
Show resolved
Hide resolved
yiguolei
reviewed
Nov 25, 2024
yiguolei
reviewed
Nov 25, 2024
fe/fe-core/src/test/java/org/apache/doris/planner/ResourceTagQueryTest.java
Show resolved
Hide resolved
yiguolei
reviewed
Nov 25, 2024
run buildall |
TPC-H: Total hot run time: 40136 ms
|
TPC-DS: Total hot run time: 196348 ms
|
ClickBench: Total hot run time: 33.83 s
|
wangbo
force-pushed
the
1118_skip_bad_replica
branch
from
November 27, 2024 03:23
1ce49b6
to
26973aa
Compare
run buildall |
TPC-H: Total hot run time: 39948 ms
|
TPC-DS: Total hot run time: 198362 ms
|
ClickBench: Total hot run time: 32.65 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Add a user property
allow_resource_tag_downgrade
, whenallow_resource_tag_downgrade = true
, it means when resource tag has no a queryable replica,then resource tag is disabled and try to find a queryable replica.In some scenarios, query success rate takes precedence over resource isolation.
currently support stream load and select.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)