Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate snapshot-id of SetStatisticsUpdate #1556

Open
kevinjqliu opened this issue Jan 21, 2025 · 4 comments
Open

Deprecate snapshot-id of SetStatisticsUpdate #1556

kevinjqliu opened this issue Jan 21, 2025 · 4 comments
Assignees

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

Following the discussion on the Mailing List:
https://lists.apache.org/thread/phxjz196zbzg0fjpfkmnj0fpkshgh9z0

Java implementation PR: OpenAPI: Deprecate snapshot-id of SetStatisticsUpdate apache/iceberg#12010

Updating table stats in pyiceberg was implemented in #1285, let's match the deprecation

@kevinjqliu
Copy link
Contributor Author

def set_statistics(self, snapshot_id: int, statistics_file: StatisticsFile) -> "UpdateStatistics":
self._updates += (
SetStatisticsUpdate(
snapshot_id=snapshot_id,
statistics=statistics_file,
),
)

@ndrluis
Copy link
Collaborator

ndrluis commented Jan 22, 2025

@kevinjqliu Since we haven't released a version with snapshot_id yet, could we just remove it? What do you think?

@kevinjqliu
Copy link
Contributor Author

@ndrluis oh yea, good catch! lets do that then

@ndrluis
Copy link
Collaborator

ndrluis commented Jan 22, 2025

ok I can help with this!

@ndrluis ndrluis self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants