From 093c33f36993caa1771e38dbad63c9f024f21db4 Mon Sep 17 00:00:00 2001 From: Chang Chen Date: Tue, 7 Nov 2023 18:32:04 +0800 Subject: [PATCH] Reopen ignore uts(https://github.com/oap-project/gluten/pull/3530/commits) due to fix(https://github.com/ClickHouse/ClickHouse/pull/56286) --- .../execution/GlutenClickHouseTPCHParquetSuite.scala | 2 +- .../glutenproject/utils/clickhouse/ClickHouseTestSettings.scala | 2 -- .../glutenproject/utils/clickhouse/ClickHouseTestSettings.scala | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/backends-clickhouse/src/test/scala/io/glutenproject/execution/GlutenClickHouseTPCHParquetSuite.scala b/backends-clickhouse/src/test/scala/io/glutenproject/execution/GlutenClickHouseTPCHParquetSuite.scala index 2602ec452f421..b8cfc81414437 100644 --- a/backends-clickhouse/src/test/scala/io/glutenproject/execution/GlutenClickHouseTPCHParquetSuite.scala +++ b/backends-clickhouse/src/test/scala/io/glutenproject/execution/GlutenClickHouseTPCHParquetSuite.scala @@ -1206,7 +1206,7 @@ class GlutenClickHouseTPCHParquetSuite extends GlutenClickHouseTPCHAbstractSuite } } - ignore("test 'cast null value' -- due to https://github.com/ClickHouse/ClickHouse/pull/55146") { + test("test 'cast null value'") { val sql = "select cast(x as double), cast(x as float), cast(x as string), cast(x as binary)," + "cast(x as long), cast(x as int), cast(x as short), cast(x as byte), cast(x as boolean)," + "cast(x as date), cast(x as timestamp), cast(x as decimal(10, 2)) from " + diff --git a/gluten-ut/spark32/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala b/gluten-ut/spark32/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala index 52f475af8b97b..3efe82eae11f0 100644 --- a/gluten-ut/spark32/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala +++ b/gluten-ut/spark32/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala @@ -574,8 +574,6 @@ class ClickHouseTestSettings extends BackendTestSettings { .exclude("SPARK-34727: cast from float II") .exclude("SPARK-35720: cast invalid string input to timestamp without time zone") .exclude("Cast should output null for invalid strings when ANSI is not enabled.") - .exclude("data type casting II") - .exclude("SPARK-36286: invalid string cast to timestamp") enableSuite[GlutenCastSuiteWithAnsiModeOn] .exclude("null cast") .exclude("cast string to date") diff --git a/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala b/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala index a2a747c4a1830..38678b2ad0d5a 100644 --- a/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala +++ b/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala @@ -614,8 +614,6 @@ class ClickHouseTestSettings extends BackendTestSettings { .exclude("SPARK-36924: Cast YearMonthIntervalType to IntegralType") .exclude("SPARK-36924: Cast IntegralType to YearMonthIntervalType") .exclude("Cast should output null for invalid strings when ANSI is not enabled.") - .exclude("data type casting II") - .exclude("SPARK-36286: invalid string cast to timestamp") enableSuite[GlutenCastSuiteWithAnsiModeOn] .exclude("null cast") .exclude("cast string to date")