From 4a613f7ff09dbf8c0cf27f67021de0dcd5910647 Mon Sep 17 00:00:00 2001 From: Chang Chen Date: Thu, 22 Aug 2024 13:34:41 +0800 Subject: [PATCH] fix race in SparkMergeTreeWriter::finalizeMerge --- .../Storages/Mergetree/SparkMergeTreeWriter.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp-ch/local-engine/Storages/Mergetree/SparkMergeTreeWriter.cpp b/cpp-ch/local-engine/Storages/Mergetree/SparkMergeTreeWriter.cpp index 93f4374d4ce1..e7d3be0db509 100644 --- a/cpp-ch/local-engine/Storages/Mergetree/SparkMergeTreeWriter.cpp +++ b/cpp-ch/local-engine/Storages/Mergetree/SparkMergeTreeWriter.cpp @@ -265,11 +265,11 @@ void SparkMergeTreeWriter::finalizeMerge() continue; GlobalThreadPool::instance().scheduleOrThrow( - [&]() -> void + [storage_ = storage, tmp = tmp_part]() -> void { - for (const auto & disk : storage->getDisks()) + for (const auto & disk : storage_->getDisks()) { - auto rel_path = storage->getRelativeDataPath() + "/" + tmp_part; + auto rel_path = storage_->getRelativeDataPath() + "/" + tmp; disk->removeRecursive(rel_path); } });