From c1e8875d4395f256cf8b81cbde3e6acc528cc222 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=88=E6=97=AD?= Date: Fri, 20 Oct 2023 10:42:39 +0800 Subject: [PATCH] address review coments --- cpp/velox/compute/VeloxBackend.cc | 1 - .../scala/io/glutenproject/utils/velox/VeloxTestSettings.scala | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/velox/compute/VeloxBackend.cc b/cpp/velox/compute/VeloxBackend.cc index 4a0f98e01d8a..a4c5ffdf3aa0 100644 --- a/cpp/velox/compute/VeloxBackend.cc +++ b/cpp/velox/compute/VeloxBackend.cc @@ -239,7 +239,6 @@ void VeloxBackend::init(const std::unordered_map& conf registerConnector(hiveConnector); velox::parquet::registerParquetReaderFactory(); velox::dwrf::registerDwrfReaderFactory(); - velox::dwrf::registerOrcReaderFactory(); // Register Velox functions registerAllFunctions(); if (!facebook::velox::isRegisteredVectorSerde()) { diff --git a/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala index 2bd2070ed260..ba4252eca6b3 100644 --- a/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala +++ b/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala @@ -773,7 +773,9 @@ class VeloxTestSettings extends BackendTestSettings { enableSuite[GlutenParquetV1AggregatePushDownSuite] enableSuite[GlutenParquetV2AggregatePushDownSuite] enableSuite[GlutenOrcV1AggregatePushDownSuite] + .exclude("nested column: Count(nested sub-field) not push down") enableSuite[GlutenOrcV2AggregatePushDownSuite] + .exclude("nested column: Count(nested sub-field) not push down") enableSuite[GlutenParquetCodecSuite] // Unsupported compression codec. .exclude("write and read - file source parquet - codec: lz4")