From c4a7368db76b6f712a5b235e104eb97ee75606c4 Mon Sep 17 00:00:00 2001 From: zml1206 Date: Tue, 10 Dec 2024 18:04:28 +0800 Subject: [PATCH] update --- .../apache/gluten/execution/BatchScanExecTransformer.scala | 4 +++- .../org/apache/gluten/expression/ExpressionConverter.scala | 7 ++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala b/gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala index 29bf1dcab6d8..67710cba072a 100644 --- a/gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala +++ b/gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala @@ -109,7 +109,9 @@ abstract class BatchScanExecTransformerBase( ExpressionConverter.replaceAttributeReference(expr), output) } - case _ => Seq.empty + case _ => + logInfo(s"${scan.getClass.toString} does not support push down filters") + Seq.empty } def setPushDownFilters(filters: Seq[Expression]): Unit = { diff --git a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala index bbcf256b5d2c..e4aeb3ef78a9 100644 --- a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala +++ b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala @@ -58,12 +58,13 @@ object ExpressionConverter extends SQLConfHelper with Logging { def canReplaceWithExpressionTransformer( expr: Expression, attributeSeq: Seq[Attribute]): Boolean = { - val expressionsMap = ExpressionMappings.expressionsMap try { - replaceWithExpressionTransformer0(expr, attributeSeq, expressionsMap) + replaceWithExpressionTransformer(expr, attributeSeq) true } catch { - case _: Exception => false + case e: Exception => + logInfo(e.getMessage) + false } }