From df3eb3fa8caa6fe3f441757179896d39844304d6 Mon Sep 17 00:00:00 2001 From: "wangguangxin.cn" Date: Wed, 14 Aug 2024 15:18:00 +0800 Subject: [PATCH] address comments --- cpp/velox/substrait/SubstraitToVeloxPlan.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cpp/velox/substrait/SubstraitToVeloxPlan.cc b/cpp/velox/substrait/SubstraitToVeloxPlan.cc index 10e4561b8ab9..7c5fc660e1f2 100644 --- a/cpp/velox/substrait/SubstraitToVeloxPlan.cc +++ b/cpp/velox/substrait/SubstraitToVeloxPlan.cc @@ -1614,8 +1614,10 @@ bool SubstraitToVeloxPlanConverter::canPushdownFunction( return false; } - // check whether data type is supported or not - if (!veloxTypeList.empty() && fieldIdx < veloxTypeList.size() && !isPushdownSupported(veloxTypeList.at(fieldIdx))) { + // Check whether data type is supported or not + if (!veloxTypeList.empty() && + fieldIdx < veloxTypeList.size() && + !isPushdownSupported(veloxTypeList.at(fieldIdx))) { return false; } @@ -1696,7 +1698,7 @@ bool SubstraitToVeloxPlanConverter::canPushdownOr( } bool SubstraitToVeloxPlanConverter::isPushdownSupported(TypePtr inputType) { - // keep the same with mapToFilters + // Keep the same with mapToFilters switch (inputType->kind()) { case TypeKind::TIMESTAMP: case TypeKind::VARBINARY: