Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix an undefined reference issue to adapt to rebased velox (11/01) #3575

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

PHILO-HE
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Nov 1, 2023

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3575_time.csv log/native_master_10_31_2023_d0ec9310f_time.csv difference percentage
q1 34.74 34.66 -0.075 99.78%
q2 24.93 24.70 -0.236 99.05%
q3 38.55 40.22 1.670 104.33%
q4 38.40 36.02 -2.378 93.81%
q5 71.44 71.14 -0.294 99.59%
q6 8.83 7.39 -1.436 83.74%
q7 88.94 88.05 -0.891 99.00%
q8 86.93 86.81 -0.116 99.87%
q9 122.36 122.50 0.140 100.11%
q10 51.19 53.84 2.649 105.17%
q11 19.53 19.59 0.062 100.32%
q12 28.08 27.64 -0.438 98.44%
q13 48.40 50.31 1.906 103.94%
q14 20.22 19.33 -0.889 95.60%
q15 34.18 34.74 0.560 101.64%
q16 15.94 16.30 0.363 102.28%
q17 102.51 102.95 0.442 100.43%
q18 147.96 147.95 -0.008 99.99%
q19 18.16 16.80 -1.359 92.52%
q20 30.80 34.80 4.009 113.02%
q21 225.34 225.79 0.454 100.20%
q22 13.41 13.35 -0.057 99.57%
total 1270.82 1274.89 4.078 100.32%

@PHILO-HE PHILO-HE changed the title [WIP] Test rebased velox [VL] Fix an undefined reference issue to adapt to rebased velox (11/01) Nov 1, 2023
@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Nov 1, 2023

TPC-DS 2TB perf. (Velox backend)

query	log/native_3575_time.csv	log/native_master_10_31_2023_time.csv	difference	percentage 
q1	10.46	10.26	-0.196	98.13% 
q2	10.41	10.74	0.329	103.16% 
q3	2.81	3.07	0.256	109.11% 
q4	60.73	84.59	23.867	139.30% 
q5	7.63	6.60	-1.033	86.46% 
q6	1.69	1.73	0.048	102.84% 
q7	4.85	4.58	-0.263	94.58% 
q8	3.81	3.80	-0.012	99.69% 
q9	20.63	21.50	0.871	104.22% 
q10	8.05	7.66	-0.396	95.09% 
q11	32.91	51.83	18.919	157.48% 
q12	2.09	1.94	-0.149	92.84% 
q13	5.46	7.06	1.600	129.31% 
q14a	41.95	39.07	-2.883	93.13% 
q14b	37.92	37.34	-0.586	98.46% 
q15	2.31	2.24	-0.071	96.95% 
q16	15.65	16.91	1.266	108.09% 
q17	4.59	3.97	-0.614	86.60% 
q18	5.52	5.46	-0.059	98.93% 
q19	2.50	1.47	-1.028	58.86% 
q20	0.94	1.77	0.827	187.83% 
q21	1.59	0.61	-0.986	38.14% 
q22	6.17	10.43	4.264	169.09% 
q23a	78.51	83.95	5.441	106.93% 
q23b	96.46	101.85	5.392	105.59% 
q24a	64.14	70.69	6.544	110.20% 
q24b	72.62	60.04	-12.581	82.68% 
q25	3.41	3.53	0.112	103.29% 
q26	2.03	1.94	-0.092	95.46% 
q27	3.07	3.23	0.162	105.29% 
q28	18.24	18.22	-0.016	99.91% 
q29	6.79	6.85	0.065	100.95% 
q30	4.20	5.36	1.158	127.53% 
q31	6.13	6.06	-0.064	98.96% 
q32	0.80	0.79	-0.010	98.78% 
q33	2.06	1.95	-0.113	94.50% 
q34	3.72	3.52	-0.196	94.72% 
q35	5.52	5.65	0.134	102.42% 
q36	2.46	2.29	-0.165	93.29% 
q37	3.33	3.42	0.088	102.63% 
q38	12.20	12.18	-0.023	99.81% 
q39a	3.72	3.60	-0.116	96.88% 
q39b	2.62	2.67	0.054	102.07% 
q40	3.94	3.91	-0.035	99.12% 
q41	0.47	0.35	-0.124	73.76% 
q42	0.49	0.51	0.015	102.98% 
q43	2.63	2.54	-0.090	96.58% 
q44	6.80	6.90	0.098	101.44% 
q45	2.47	2.60	0.125	105.07% 
q46	2.51	2.43	-0.080	96.83% 
q47	14.42	14.93	0.512	103.55% 
q48	4.06	3.94	-0.121	97.03% 
q49	6.71	6.60	-0.102	98.48% 
q50	21.64	22.60	0.963	104.45% 
q51	7.86	7.97	0.113	101.44% 
q52	0.63	0.73	0.100	115.74% 
q53	1.61	1.51	-0.093	94.19% 
q54	2.88	2.73	-0.150	94.78% 
q55	0.58	0.53	-0.049	91.49% 
q56	1.32	1.39	0.077	105.86% 
q57	7.95	8.02	0.071	100.90% 
q58	2.02	2.25	0.229	111.36% 
q59	5.46	5.31	-0.148	97.28% 
q60	2.06	2.95	0.895	143.49% 
q61	2.02	1.96	-0.051	97.47% 
q62	3.48	3.59	0.113	103.24% 
q63	1.39	1.43	0.042	103.04% 
q64	27.85	27.61	-0.239	99.14% 
q65	13.84	13.98	0.134	100.97% 
q66	2.37	2.36	-0.010	99.59% 
q67	366.24	434.63	68.392	118.67% 
q68	1.44	2.02	0.586	140.69% 
q69	4.97	4.91	-0.060	98.80% 
q70	6.74	7.45	0.713	110.57% 
q71	1.90	1.96	0.053	102.78% 
q72	29.04	28.57	-0.466	98.39% 
q73	1.69	1.71	0.026	101.52% 
q74	19.78	26.06	6.284	131.78% 
q75	26.74	27.11	0.369	101.38% 
q76	9.23	9.02	-0.209	97.74% 
q77	1.73	1.69	-0.036	97.95% 
q78	38.74	38.97	0.228	100.59% 
q79	3.24	3.24	-0.001	99.97% 
q80	11.51	11.44	-0.071	99.39% 
q81	3.97	3.90	-0.072	98.18% 
q82	6.09	6.12	0.032	100.52% 
q83	0.98	1.24	0.257	126.27% 
q84	2.46	2.47	0.006	100.24% 
q85	6.52	6.86	0.338	105.19% 
q86	2.42	2.35	-0.080	96.72% 
q87	12.35	12.47	0.113	100.92% 
q88	17.57	17.05	-0.520	97.04% 
q89	2.05	2.16	0.119	105.80% 
q90	2.90	2.97	0.062	102.13% 
q91	1.81	1.82	0.011	100.60% 
q92	0.91	0.77	-0.138	84.78% 
q93	26.11	26.22	0.110	100.42% 
q94	9.65	10.36	0.709	107.35% 
q95	65.79	65.79	0.000	100.00% 
q96	2.38	2.47	0.093	103.90% 
q97	18.30	18.20	-0.099	99.46% 
q98	1.31	1.23	-0.073	94.43% 
q99	8.69	8.00	-0.692	92.04% 
total	1547.40	1675.33	127.925	108.27% 

@PHILO-HE PHILO-HE merged commit 697b2bd into apache:main Nov 1, 2023
14 of 15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3575_time.csv log/native_master_10_31_2023_d0ec9310f_time.csv difference percentage
q1 34.86 34.66 -0.203 99.42%
q2 24.13 24.70 0.570 102.36%
q3 40.40 40.22 -0.173 99.57%
q4 37.76 36.02 -1.742 95.39%
q5 71.11 71.14 0.033 100.05%
q6 8.62 7.39 -1.230 85.74%
q7 84.53 88.05 3.519 104.16%
q8 85.81 86.81 0.998 101.16%
q9 124.35 122.50 -1.850 98.51%
q10 49.63 53.84 4.213 108.49%
q11 20.20 19.59 -0.612 96.97%
q12 25.65 27.64 1.996 107.78%
q13 48.92 50.31 1.382 102.82%
q14 18.54 19.33 0.785 104.23%
q15 34.77 34.74 -0.032 99.91%
q16 16.07 16.30 0.234 101.46%
q17 101.71 102.95 1.236 101.22%
q18 148.17 147.95 -0.218 99.85%
q19 16.94 16.80 -0.141 99.17%
q20 31.67 34.80 3.129 109.88%
q21 222.79 225.79 3.006 101.35%
q22 13.69 13.35 -0.339 97.53%
total 1260.33 1274.89 14.562 101.16%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_01_2023_time.csv log/native_master_10_31_2023_d0ec9310f_time.csv difference percentage
q1 34.18 34.66 0.486 101.42%
q2 24.84 24.70 -0.145 99.41%
q3 40.06 40.22 0.164 100.41%
q4 37.29 36.02 -1.263 96.61%
q5 71.36 71.14 -0.220 99.69%
q6 8.95 7.39 -1.556 82.61%
q7 86.23 88.05 1.819 102.11%
q8 84.56 86.81 2.253 102.66%
q9 121.30 122.50 1.199 100.99%
q10 50.93 53.84 2.909 105.71%
q11 20.30 19.59 -0.713 96.49%
q12 26.50 27.64 1.138 104.29%
q13 48.85 50.31 1.453 102.97%
q14 18.13 19.33 1.193 106.58%
q15 35.06 34.74 -0.325 99.07%
q16 16.16 16.30 0.136 100.84%
q17 102.07 102.95 0.879 100.86%
q18 149.11 147.95 -1.162 99.22%
q19 18.26 16.80 -1.456 92.02%
q20 31.06 34.80 3.745 112.06%
q21 223.74 225.79 2.053 100.92%
q22 13.21 13.35 0.146 101.10%
total 1262.16 1274.89 12.734 101.01%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants