[VL] Fix a bug that may break bhj + exchange validation in a corner case #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
/Benchmark Velox |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
zhztheplayer
commented
Nov 3, 2023
Comment on lines
555
to
+558
| TransformHints.tag(bhj, isBhjTransformable.toTransformHint) | ||
| TransformHints.tagNotTransformable(exchange, isBhjTransformable) | ||
| if (!isBhjTransformable.isValid) { | ||
| TransformHints.tagNotTransformable(exchange, isBhjTransformable) | ||
| } |
There was a problem hiding this comment.
Once exchange was already tagged as transformable, This code may still re-tag it as non-transformable if bhj is considered non-transformable in validation at the time.
zhztheplayer
commented
Nov 3, 2023
Comment on lines
+317
to
+319
| val out = plan.withNewChildren(plan.children.map(addTransformableTags)) | ||
| addTransformableTag(out) | ||
| out |
There was a problem hiding this comment.
This ensures bhj is validated after the corresponding exchange is validated
zhztheplayer
changed the title
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous bhj + exchange joint validation may not work because of bugs. The patch is to fix the broken logic.