Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix ExpandExecTransformer miss input #3665

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Before this pr, the ExpandExecTransformer would miss input. It does not affect the result for now, but better to avoid potential issue in future.

image

How was this patch tested?

Pass CI

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ulysses-you ulysses-you merged commit 797770d into apache:main Nov 10, 2023
17 checks passed
@ulysses-you ulysses-you deleted the expand branch November 10, 2023 06:58
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3665_time.csv log/native_master_11_09_2023_745ecb383_time.csv difference percentage
q1 33.69 33.80 0.111 100.33%
q2 24.37 24.95 0.578 102.37%
q3 38.38 38.87 0.488 101.27%
q4 37.43 36.96 -0.468 98.75%
q5 70.91 69.94 -0.973 98.63%
q6 6.64 7.87 1.228 118.48%
q7 81.01 85.40 4.388 105.42%
q8 86.55 88.61 2.058 102.38%
q9 127.11 121.14 -5.975 95.30%
q10 43.68 54.35 10.663 124.41%
q11 20.39 19.52 -0.875 95.71%
q12 24.66 24.93 0.271 101.10%
q13 46.65 50.92 4.265 109.14%
q14 13.77 18.17 4.395 131.92%
q15 29.44 30.79 1.352 104.59%
q16 15.31 16.06 0.757 104.94%
q17 100.34 101.51 1.170 101.17%
q18 148.08 148.23 0.152 100.10%
q19 14.41 14.95 0.544 103.77%
q20 27.37 31.24 3.867 114.13%
q21 222.39 223.30 0.908 100.41%
q22 12.98 14.24 1.256 109.67%
total 1225.58 1255.74 30.161 102.46%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_10_2023_time.csv log/native_master_11_09_2023_745ecb383_time.csv difference percentage
q1 33.45 33.80 0.349 101.04%
q2 24.39 24.95 0.564 102.31%
q3 36.81 38.87 2.056 105.58%
q4 36.26 36.96 0.703 101.94%
q5 70.82 69.94 -0.875 98.76%
q6 7.02 7.87 0.850 112.10%
q7 84.35 85.40 1.057 101.25%
q8 86.64 88.61 1.972 102.28%
q9 125.36 121.14 -4.224 96.63%
q10 44.33 54.35 10.015 122.59%
q11 19.48 19.52 0.033 100.17%
q12 26.73 24.93 -1.801 93.26%
q13 46.07 50.92 4.845 110.52%
q14 16.32 18.17 1.843 111.29%
q15 28.74 30.79 2.054 107.15%
q16 15.18 16.06 0.888 105.85%
q17 100.88 101.51 0.637 100.63%
q18 146.91 148.23 1.316 100.90%
q19 13.11 14.95 1.843 114.06%
q20 27.34 31.24 3.896 114.25%
q21 220.84 223.30 2.467 101.12%
q22 13.13 14.24 1.104 108.41%
total 1224.15 1255.74 31.593 102.58%

ulysses-you added a commit to ulysses-you/gluten that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants