-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] [Minor] Fix compile error in debug mode #3765
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JkSelf I assume the CI errors are not related?
#3748 will remove GLUTEN_PRINT_DEBUG macro in most cases, and refine printConfig usage, maybe we can fix this issue in that patch. |
1 similar comment
#3748 will remove GLUTEN_PRINT_DEBUG macro in most cases, and refine printConfig usage, maybe we can fix this issue in that patch. |
@Yohahaha Thanks. And would you like to rebase your work after this patch gets merged? Since this one is small and very close to being ready. |
OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
We don't have debug build test on CI yet. Verified locally. |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Fix the following compile error in debug mode.
How was this patch tested?
local debug mode compile.