Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] [Minor] Fix compile error in debug mode #3765

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Nov 17, 2023

What changes were proposed in this pull request?

Fix the following compile error in debug mode.

/mnt/DP_disk1/sparkuser/projects/gluten/cpp/velox/compute/VeloxBackend.cc: In member function ‘void gluten::VeloxBackend::init(const std::unordered_map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&)’:
/mnt/DP_disk1/sparkuser/projects/gluten/cpp/velox/compute/VeloxBackend.cc:204:13: error: cannot convert ‘const facebook::velox::Config*’ to ‘const facebook::velox::Config&’
  204 |   printConf(veloxcfg);
      |             ^~~~~~~~
      |             |
      |             const facebook::velox::Config*
/mnt/DP_disk1/sparkuser/projects/gluten/cpp/velox/compute/VeloxBackend.cc:111:61: note:   initializing argument 1 of ‘void gluten::VeloxBackend::printConf(const facebook::velox::Config&)’
  111 | void VeloxBackend::printConf(const facebook::velox::Config& conf) {
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
make[2]: *** [velox/CMakeFiles/velox.dir/build.make:63: velox/CMakeFiles/velox.dir/compute/VeloxBackend.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:192: velox/CMakeFiles/velox.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

How was this patch tested?

local debug mode compile.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer zhztheplayer changed the title [VL] [Minor] fix compile error in debug mode [VL] [Minor] Fix compile error in debug mode Nov 20, 2023
zhztheplayer
zhztheplayer previously approved these changes Nov 20, 2023
Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JkSelf I assume the CI errors are not related?

@Yohahaha
Copy link
Contributor

#3748 will remove GLUTEN_PRINT_DEBUG macro in most cases, and refine printConfig usage, maybe we can fix this issue in that patch.

1 similar comment
@Yohahaha
Copy link
Contributor

#3748 will remove GLUTEN_PRINT_DEBUG macro in most cases, and refine printConfig usage, maybe we can fix this issue in that patch.

@zhztheplayer
Copy link
Member

zhztheplayer commented Nov 20, 2023

@Yohahaha Thanks. And would you like to rebase your work after this patch gets merged? Since this one is small and very close to being ready.

@Yohahaha
Copy link
Contributor

@Yohahaha Thanks. And would you like to rebase your work after this patch gets merged? Since this one is small and very close to being ready.

OK.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zhztheplayer
Copy link
Member

We don't have debug build test on CI yet. Verified locally.

@zhztheplayer zhztheplayer merged commit 7553cd1 into apache:main Nov 20, 2023
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3765_time.csv log/native_master_11_19_2023_5f5d18abe_time.csv difference percentage
q1 34.20 34.50 0.297 100.87%
q2 24.84 24.57 -0.276 98.89%
q3 37.68 37.14 -0.542 98.56%
q4 35.38 36.74 1.355 103.83%
q5 68.80 70.93 2.127 103.09%
q6 5.47 7.09 1.617 129.56%
q7 82.71 83.62 0.907 101.10%
q8 87.38 85.87 -1.512 98.27%
q9 120.98 126.22 5.239 104.33%
q10 43.37 46.75 3.379 107.79%
q11 19.73 19.85 0.114 100.58%
q12 27.55 25.57 -1.981 92.81%
q13 45.40 45.26 -0.140 99.69%
q14 16.05 18.39 2.338 114.56%
q15 29.16 28.36 -0.798 97.26%
q16 15.44 15.85 0.407 102.63%
q17 100.79 100.27 -0.521 99.48%
q18 147.56 147.67 0.110 100.07%
q19 14.29 13.00 -1.300 90.91%
q20 27.52 26.75 -0.778 97.18%
q21 220.00 222.79 2.791 101.27%
q22 13.06 13.20 0.134 101.03%
total 1217.40 1230.37 12.968 101.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants