Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Fix due to https://github.com/oap-project/gluten/pull/3756 #3769

Closed
baibaichen opened this issue Nov 18, 2023 · 1 comment
Closed

Revert Fix due to https://github.com/oap-project/gluten/pull/3756 #3769

baibaichen opened this issue Nov 18, 2023 · 1 comment
Assignees
@baibaichen
Labels
triage

Comments

@baibaichen
Copy link
Contributor

baibaichen commented Nov 18, 2023 •
edited
Loading

Problem description

In #3756, we fix build by introducing -Wno-extra-semi-stmt and -Wno-used-but-marked-unused, it seems ClickHouse/ClickHouse#56853 fix that. let's revert them in the next upgrade.

System information

no

CMake log

No response
@baibaichen baibaichen self-assigned this Nov 18, 2023
@baibaichen baibaichen mentioned this issue Nov 22, 2023
Merged
@baibaichen
Copy link
Contributor Author

FIXED BY #3802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baibaichen baibaichen

Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baibaichen