Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix QAT codec not closed #3840

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[VL] Fix QAT codec not closed #3840

merged 1 commit into from
Nov 24, 2023

Conversation

marin-ma
Copy link
Contributor

Some of the inner structures of qzSession_ are not released without calling qzTeardownSession.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@marin-ma marin-ma requested a review from zhouyuan November 24, 2023 08:25
@zhouyuan
Copy link
Contributor

it seems there is another flaky unit tests, the failure is not related

@zhouyuan zhouyuan merged commit f456a7e into apache:main Nov 24, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3840_time.csv log/native_master_11_23_2023_df3eb372c_time.csv difference percentage
q1 34.06 34.09 0.027 100.08%
q2 25.68 24.43 -1.252 95.13%
q3 37.23 37.11 -0.121 99.67%
q4 37.63 35.49 -2.142 94.31%
q5 68.92 70.74 1.826 102.65%
q6 7.49 6.77 -0.726 90.31%
q7 85.60 85.18 -0.411 99.52%
q8 86.84 84.73 -2.112 97.57%
q9 123.97 118.73 -5.240 95.77%
q10 46.04 43.59 -2.455 94.67%
q11 20.09 19.61 -0.483 97.59%
q12 25.38 23.77 -1.615 93.64%
q13 44.85 45.78 0.925 102.06%
q14 17.21 17.52 0.309 101.79%
q15 28.05 28.14 0.086 100.30%
q16 15.27 15.14 -0.122 99.20%
q17 100.50 100.38 -0.116 99.88%
q18 149.13 147.08 -2.057 98.62%
q19 15.36 12.95 -2.405 84.34%
q20 27.60 28.07 0.478 101.73%
q21 220.45 218.99 -1.456 99.34%
q22 13.32 12.93 -0.386 97.10%
total 1230.68 1211.23 -19.449 98.42%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_24_2023_time.csv log/native_master_11_23_2023_df3eb372c_time.csv difference percentage
q1 33.35 34.09 0.742 102.23%
q2 24.67 24.43 -0.241 99.02%
q3 37.24 37.11 -0.133 99.64%
q4 37.78 35.49 -2.292 93.93%
q5 70.24 70.74 0.497 100.71%
q6 7.16 6.77 -0.392 94.52%
q7 85.72 85.18 -0.532 99.38%
q8 86.74 84.73 -2.006 97.69%
q9 121.43 118.73 -2.696 97.78%
q10 46.25 43.59 -2.658 94.25%
q11 19.13 19.61 0.476 102.49%
q12 26.08 23.77 -2.309 91.14%
q13 45.82 45.78 -0.037 99.92%
q14 16.35 17.52 1.174 107.18%
q15 27.86 28.14 0.276 100.99%
q16 15.81 15.14 -0.669 95.77%
q17 103.10 100.38 -2.718 97.36%
q18 148.87 147.08 -1.796 98.79%
q19 12.91 12.95 0.041 100.32%
q20 27.27 28.07 0.803 102.95%
q21 221.84 218.99 -2.850 98.72%
q22 13.56 12.93 -0.622 95.41%
total 1229.17 1211.23 -17.940 98.54%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_25_2023_time.csv log/native_master_11_24_2023_f456a7e86_time.csv difference percentage
q1 33.92 33.35 -0.571 98.32%
q2 24.63 24.67 0.038 100.15%
q3 37.97 37.24 -0.726 98.09%
q4 36.67 37.78 1.106 103.02%
q5 70.09 70.24 0.158 100.23%
q6 6.75 7.16 0.408 106.04%
q7 83.98 85.72 1.735 102.07%
q8 86.87 86.74 -0.134 99.85%
q9 123.67 121.43 -2.239 98.19%
q10 44.37 46.25 1.874 104.22%
q11 19.78 19.13 -0.647 96.73%
q12 28.12 26.08 -2.041 92.74%
q13 45.86 45.82 -0.042 99.91%
q14 18.47 16.35 -2.121 88.52%
q15 29.09 27.86 -1.229 95.78%
q16 15.40 15.81 0.418 102.72%
q17 99.59 103.10 3.508 103.52%
q18 147.30 148.87 1.572 101.07%
q19 12.94 12.91 -0.030 99.77%
q20 27.33 27.27 -0.061 99.78%
q21 219.66 221.84 2.189 101.00%
q22 12.88 13.56 0.679 105.27%
total 1225.33 1229.17 3.843 100.31%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_26_2023_time.csv log/native_master_11_25_2023_f456a7e86_time.csv difference percentage
q1 34.38 33.92 -0.465 98.65%
q2 24.62 24.63 0.008 100.03%
q3 37.74 37.97 0.223 100.59%
q4 36.67 36.67 0.001 100.00%
q5 68.82 70.09 1.269 101.84%
q6 7.12 6.75 -0.364 94.89%
q7 82.01 83.98 1.969 102.40%
q8 87.72 86.87 -0.854 99.03%
q9 120.79 123.67 2.877 102.38%
q10 44.22 44.37 0.158 100.36%
q11 19.96 19.78 -0.176 99.12%
q12 28.56 28.12 -0.444 98.45%
q13 46.61 45.86 -0.747 98.40%
q14 14.35 18.47 4.119 128.71%
q15 29.15 29.09 -0.060 99.79%
q16 15.41 15.40 -0.012 99.92%
q17 100.98 99.59 -1.387 98.63%
q18 145.61 147.30 1.694 101.16%
q19 12.88 12.94 0.058 100.45%
q20 27.79 27.33 -0.463 98.33%
q21 223.56 219.66 -3.905 98.25%
q22 13.03 12.88 -0.156 98.81%
total 1221.98 1225.33 3.343 100.27%

@marin-ma marin-ma deleted the fix-qat-close branch June 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants