Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Improve merge fallback reason #3981

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

A logical link can map to several physical plan which would cause the fallback reason loss. e.g., the logical link of FilterExec(FileSourceScanExec) is same with FileSourceScanExec. So this pr adds all reason into that logical link to make sure we do not lose any fallback reason.

Besides, this pr reduces the noisy fallback reason which is produced by ExpandFallbackPolicy if there already exists fallback reason.

How was this patch tested?

add tests

Copy link

github-actions bot commented Dec 8, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

2 similar comments
@ulysses-you
Copy link
Contributor Author

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
@ulysses-you
Copy link
Contributor Author

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

cc @PHILO-HE thank you

@ulysses-you
Copy link
Contributor Author

The CH backend CI is passed

@yaooqinn yaooqinn merged commit 2bdf16c into apache:main Dec 13, 2023
10 checks passed
Copy link

Run Gluten Clickhouse CI

@ulysses-you ulysses-you deleted the fallback branch December 13, 2023 03:00
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3981_time.csv log/native_master_12_12_2023_8c6f1643e_time.csv difference percentage
q1 32.39 33.75 1.359 104.20%
q2 24.08 24.88 0.806 103.35%
q3 37.68 37.71 0.022 100.06%
q4 40.49 37.86 -2.635 93.49%
q5 69.89 72.83 2.941 104.21%
q6 5.43 7.05 1.619 129.81%
q7 87.37 86.50 -0.873 99.00%
q8 86.79 86.24 -0.548 99.37%
q9 121.68 125.50 3.825 103.14%
q10 44.83 44.68 -0.150 99.67%
q11 19.61 20.21 0.605 103.09%
q12 26.91 25.06 -1.849 93.13%
q13 46.11 46.58 0.471 101.02%
q14 18.96 19.99 1.031 105.44%
q15 27.92 27.55 -0.376 98.65%
q16 15.85 15.86 0.007 100.05%
q17 104.99 103.27 -1.720 98.36%
q18 154.09 151.33 -2.759 98.21%
q19 13.28 13.89 0.608 104.57%
q20 27.44 28.68 1.248 104.55%
q21 226.93 229.12 2.193 100.97%
q22 13.79 13.95 0.159 101.15%
total 1246.51 1252.49 5.987 100.48%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants