-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Improve merge fallback reason #3981
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
2485c9b
to
455e24c
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
cc @PHILO-HE thank you |
The CH backend CI is passed |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
A logical link can map to several physical plan which would cause the fallback reason loss. e.g., the logical link of
FilterExec(FileSourceScanExec)
is same withFileSourceScanExec
. So this pr adds all reason into that logical link to make sure we do not lose any fallback reason.Besides, this pr reduces the noisy fallback reason which is produced by
ExpandFallbackPolicy
if there already exists fallback reason.How was this patch tested?
add tests