Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] No need to compare all the agg mode in checkAggFuncModeSupport #4761

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

No need to compare all the agg mode in checkAggFuncModeSupport.

How was this patch tested?

Exists CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

cc @ulysses-you, thanks.

Copy link

Run Gluten Clickhouse CI

@ulysses-you ulysses-you merged commit 6c358d5 into apache:main Feb 26, 2024
19 checks passed
@liujiayi771 liujiayi771 deleted the agg-mode branch February 26, 2024 01:20
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4761_time.csv log/native_master_02_25_2024_f25a372a2_time.csv difference percentage
q1 36.42 35.29 -1.127 96.90%
q2 24.43 24.66 0.227 100.93%
q3 37.89 38.19 0.303 100.80%
q4 38.03 37.65 -0.383 98.99%
q5 70.55 71.07 0.525 100.74%
q6 7.03 7.10 0.075 101.07%
q7 83.65 83.73 0.078 100.09%
q8 86.59 86.10 -0.485 99.44%
q9 123.71 124.35 0.637 100.51%
q10 43.43 42.79 -0.636 98.54%
q11 20.22 20.17 -0.050 99.75%
q12 28.27 28.36 0.089 100.32%
q13 45.39 44.51 -0.882 98.06%
q14 16.42 18.87 2.444 114.88%
q15 28.87 27.68 -1.192 95.87%
q16 15.74 14.41 -1.334 91.53%
q17 101.74 101.11 -0.631 99.38%
q18 147.93 148.83 0.894 100.60%
q19 12.78 15.99 3.211 125.12%
q20 26.44 26.47 0.023 100.09%
q21 224.67 227.71 3.036 101.35%
q22 13.84 13.61 -0.227 98.36%
total 1234.06 1238.65 4.594 100.37%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants