-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Add support of percentile_approx / approx_percentile #4889
Comments
cc @liujiayi771 @ulysses-you I took the function in #4039 but may delay the implementation. I see you have been actively working on aggregation functions in past a few of days so (you or anyone) please feel free to take this issue if interested. It looks like the new utility introduced by #4764 could help a lot here but may still require for some changes though. I am not sure and you may have more context in there than me. |
Thank you @zhztheplayer for driving this, I think @liujiayi771 is the better one to take it :) |
@zhztheplayer I can come to add these aggregate functions, thanks. |
@liujiayi771 Glad to hear you'll help. I'll reassign the task to you. Thanks! |
I have a draft version before, and I can take over this if you have not start yet @liujiayi771 @zhztheplayer |
@WangGuangxin I have not started yet, feel free to take it. |
Description
Part of #4039
Velox(presto)'s
approx_percentile
has different intermediate types with Spark's function with same name.Velox's signature code of
approx_percentile
:Link https://github.com/facebookincubator/velox/blob/main/velox/functions/prestosql/aggregates/ApproxPercentileAggregate.cpp#L790C1-L828C1
Spark's code of
approx_percentile
/percentile_approx
:https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
The text was updated successfully, but these errors were encountered: