-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-4917][VL] CI: update GHA docker image #5907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_ci_update_docker_image
branch
from
May 29, 2024 05:13
fb71672
to
60a1acd
Compare
zhouyuan
commented
May 29, 2024
@@ -2,7 +2,7 @@ yum install sudo patch java-1.8.0-openjdk-devel -y | |||
cd $GITHUB_WORKSPACE/ep/build-velox/src | |||
./get_velox.sh | |||
source /opt/rh/devtoolset-9/enable | |||
source $GITHUB_WORKSPACE/dev/vcpkg/env.sh | |||
source /opt/gluten/dev/vcpkg/env.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhztheplayer just brought this change back
zhztheplayer
approved these changes
May 29, 2024
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
note: vcpkg is not able to detect the changes on compile flags - in this case it needs to force recompile the lib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
update GHA docker image to add folly changes
#5314
How was this patch tested?
pass GHA