Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4917][VL] CI: update GHA docker image #5907

Merged
merged 1 commit into from
May 29, 2024

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented May 29, 2024

What changes were proposed in this pull request?

update GHA docker image to add folly changes
#5314

How was this patch tested?

pass GHA

Copy link

#4917

@zhouyuan zhouyuan force-pushed the wip_ci_update_docker_image branch from fb71672 to 60a1acd Compare May 29, 2024 05:13
@@ -2,7 +2,7 @@ yum install sudo patch java-1.8.0-openjdk-devel -y
cd $GITHUB_WORKSPACE/ep/build-velox/src
./get_velox.sh
source /opt/rh/devtoolset-9/enable
source $GITHUB_WORKSPACE/dev/vcpkg/env.sh
source /opt/gluten/dev/vcpkg/env.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhztheplayer just brought this change back

@zhouyuan zhouyuan merged commit 92798a2 into apache:main May 29, 2024
39 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5907_time.csv log/native_master_05_28_2024_d7374bd8f_time.csv difference percentage
q1 33.70 34.04 0.344 101.02%
q2 23.99 23.62 -0.363 98.49%
q3 35.07 36.93 1.863 105.31%
q4 32.85 32.10 -0.747 97.73%
q5 69.21 69.91 0.700 101.01%
q6 7.27 5.97 -1.308 82.02%
q7 81.91 80.25 -1.653 97.98%
q8 83.93 84.79 0.857 101.02%
q9 120.16 121.55 1.386 101.15%
q10 45.85 43.64 -2.207 95.19%
q11 20.47 22.27 1.799 108.79%
q12 29.02 26.90 -2.121 92.69%
q13 51.21 52.40 1.194 102.33%
q14 19.47 21.59 2.124 110.91%
q15 29.48 31.46 1.981 106.72%
q16 13.58 13.97 0.387 102.85%
q17 104.78 102.83 -1.955 98.13%
q18 145.00 145.92 0.913 100.63%
q19 15.81 14.82 -0.997 93.70%
q20 26.86 31.06 4.202 115.65%
q21 257.19 261.69 4.497 101.75%
q22 12.06 12.27 0.202 101.68%
total 1258.88 1269.97 11.100 100.88%

@zhouyuan
Copy link
Contributor Author

note: vcpkg is not able to detect the changes on compile flags - in this case it needs to force recompile the lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants