Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH][UT] Fix UT due to https://github.com/ClickHouse/ClickHouse/pull/64427 #6079

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

baibaichen
Copy link
Contributor

What changes were proposed in this pull request?

Don't know the reason, but this PR changed the input_format_parquet_max_block_size to DEFAULT_block_size, which is 65409, causing the MergeTree related tests to fail. Let's set input_format_parquet_max_block_size to 8192, which reverts 7445f02 (this fix looks unstable)

Also I use assertResult instead of assert, so we can know the actual result once failed.

How was this patch tested?

Existed UTs

Don't know the reason, but this PR changed the 'input_format_parquet_max_block_size' to 'DEFAULT_block_size', which is 65409, causing the MergeTree related tests to fail.  Let's set input_format_parquet_max_block_size to 8192, which reverts 7445f02

Also I use assertResult instead of assert, so we can know the actual result once failed.
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 142cf0f into apache:main Jun 13, 2024
7 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_06_13_2024_time.csv log/native_master_06_12_2024_7f8d2330e_time.csv difference percentage
q1 15.69 15.06 -0.628 95.99%
q2 15.39 14.47 -0.913 94.06%
q3 4.29 4.34 0.051 101.19%
q4 65.30 62.74 -2.562 96.08%
q5 7.66 6.59 -1.064 86.10%
q6 7.58 3.54 -4.034 46.76%
q7 6.41 5.42 -0.991 84.53%
q8 5.26 8.56 3.305 162.85%
q9 17.10 17.93 0.829 104.85%
q10 9.02 10.33 1.314 114.57%
q11 35.38 35.53 0.148 100.42%
q12 1.38 1.42 0.041 102.96%
q13 5.33 5.33 0.004 100.07%
q14a 41.18 40.29 -0.886 97.85%
q14b 41.74 38.76 -2.982 92.86%
q15 2.59 2.38 -0.207 91.99%
q16 38.11 39.72 1.613 104.23%
q17 5.50 4.39 -1.104 79.91%
q18 6.04 5.79 -0.251 95.85%
q19 2.09 3.51 1.427 168.43%
q20 1.28 1.41 0.136 110.66%
q21 0.94 1.08 0.137 114.60%
q22 9.32 8.23 -1.086 88.34%
q23a 79.23 80.13 0.895 101.13%
q23b 99.56 100.39 0.831 100.84%
q24a 68.73 69.28 0.555 100.81%
q24b 72.86 69.26 -3.608 95.05%
q25 3.98 5.81 1.832 146.02%
q26 2.60 4.41 1.808 169.63%
q27 2.94 2.91 -0.028 99.06%
q28 23.86 19.95 -3.905 83.63%
q29 7.79 9.53 1.740 122.34%
q30 4.42 4.11 -0.306 93.06%
q31 7.60 5.94 -1.661 78.14%
q32 1.07 2.23 1.162 208.42%
q33 5.60 4.81 -0.794 85.83%
q34 5.77 4.76 -1.009 82.51%
q35 6.77 6.39 -0.384 94.33%
q36 3.30 3.23 -0.072 97.82%
q37 4.28 3.89 -0.385 90.99%
q38 11.89 11.70 -0.188 98.42%
q39a 4.08 3.09 -0.993 75.67%
q39b 2.91 2.79 -0.121 95.84%
q40 4.50 3.78 -0.717 84.06%
q41 0.63 3.90 3.273 619.87%
q42 0.96 0.91 -0.052 94.62%
q43 3.66 3.70 0.042 101.15%
q44 7.77 7.29 -0.483 93.79%
q45 4.96 3.36 -1.605 67.66%
q46 2.99 3.17 0.180 106.03%
q47 14.13 13.87 -0.264 98.14%
q48 4.18 4.24 0.058 101.39%
q49 7.23 7.38 0.157 102.17%
q50 29.75 20.80 -8.943 69.94%
q51 8.24 8.53 0.285 103.46%
q52 0.97 0.95 -0.023 97.65%
q53 1.71 1.87 0.161 109.43%
q54 3.14 2.98 -0.160 94.90%
q55 1.08 0.96 -0.126 88.36%
q56 4.50 4.31 -0.186 95.87%
q57 8.71 8.43 -0.288 96.69%
q58 2.43 2.53 0.104 104.27%
q59 15.31 13.61 -1.700 88.90%
q60 4.71 4.69 -0.019 99.59%
q61 5.36 5.18 -0.181 96.62%
q62 3.79 3.62 -0.163 95.70%
q63 2.07 1.84 -0.233 88.74%
q64 56.97 53.29 -3.686 93.53%
q65 13.73 13.60 -0.129 99.06%
q66 3.37 3.04 -0.331 90.17%
q67 364.30 353.95 -10.346 97.16%
q68 3.71 3.79 0.079 102.13%
q69 6.44 6.46 0.014 100.22%
q70 8.42 8.52 0.104 101.23%
q71 2.25 3.51 1.258 155.85%
q72 186.39 192.02 5.634 103.02%
q73 1.94 2.25 0.315 116.28%
q74 20.93 23.98 3.050 114.58%
q75 23.12 21.08 -2.036 91.19%
q76 11.41 7.44 -3.967 65.22%
q77 1.75 1.84 0.093 105.32%
q78 44.37 38.13 -6.237 85.94%
q79 3.56 3.44 -0.126 96.45%
q80 13.02 10.60 -2.415 81.45%
q81 4.43 4.41 -0.024 99.45%
q82 6.17 6.29 0.122 101.98%
q83 1.47 1.46 -0.014 99.08%
q84 4.22 2.72 -1.505 64.38%
q85 6.70 6.49 -0.219 96.74%
q86 3.45 3.13 -0.316 90.84%
q87 12.14 15.57 3.434 128.29%
q88 20.55 16.94 -3.605 82.45%
q89 2.76 2.63 -0.135 95.10%
q90 2.86 3.19 0.333 111.66%
q91 3.16 2.47 -0.696 78.00%
q92 1.30 1.21 -0.095 92.69%
q93 31.91 28.60 -3.307 89.63%
q94 22.55 22.61 0.054 100.24%
q9 88.12 80.76 -7.361 91.65%
q5 2.63 2.53 -0.105 96.02%
q96 12.01 11.97 -0.038 99.68%
q97 2.01 1.89 -0.122 93.96%
q98 8.89 11.17 2.281 125.65%
q99 8.89 11.17 2.281 125.65%
total 1909.59 1856.33 -53.262 97.21%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_06_13_2024_time.csv log/native_master_06_12_2024_7445f02c9_time.csv difference percentage
q1 35.57 33.87 -1.694 95.24%
q2 23.78 26.51 2.724 111.46%
q3 39.61 36.94 -2.662 93.28%
q4 32.76 34.65 1.887 105.76%
q5 67.54 69.47 1.928 102.85%
q6 9.42 5.84 -3.576 62.02%
q7 80.69 82.18 1.483 101.84%
q8 84.77 85.19 0.416 100.49%
q9 120.70 120.19 -0.516 99.57%
q10 45.25 43.54 -1.711 96.22%
q11 19.79 20.47 0.682 103.45%
q12 27.92 24.09 -3.827 86.29%
q13 39.43 37.22 -2.213 94.39%
q14 18.98 23.00 4.013 121.14%
q15 33.04 30.20 -2.842 91.40%
q16 13.85 13.79 -0.065 99.53%
q17 101.57 102.85 1.280 101.26%
q18 144.97 145.02 0.053 100.04%
q19 13.79 16.14 2.348 117.02%
q20 26.68 27.34 0.666 102.50%
q21 260.83 263.30 2.468 100.95%
q22 13.91 12.08 -1.831 86.84%
total 1254.85 1253.86 -0.989 99.92%

@baibaichen baibaichen deleted the feature/Fix_UT branch June 14, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants