-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CH][UT] Fix UT due to https://github.com/ClickHouse/ClickHouse/pull/64427 #6079
Conversation
Don't know the reason, but this PR changed the 'input_format_parquet_max_block_size' to 'DEFAULT_block_size', which is 65409, causing the MergeTree related tests to fail. Let's set input_format_parquet_max_block_size to 8192, which reverts 7445f02 Also I use assertResult instead of assert, so we can know the actual result once failed.
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Don't know the reason, but this PR changed the
input_format_parquet_max_block_size
toDEFAULT_block_size
, which is 65409, causing the MergeTree related tests to fail. Let's setinput_format_parquet_max_block_size
to 8192, which reverts 7445f02 (this fix looks unstable)Also I use
assertResult
instead ofassert
, so we can know the actual result once failed.How was this patch tested?
Existed UTs