[VL] Add test for log function #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
reviewed
Jun 25, 2024
| @@ -407,7 +407,8 @@ std::unordered_map<std::string, std::string> SubstraitParser::substraitVeloxFunc | |||
| {"exists", "any_match"}, | |||
| {"negative", "unaryminus"}, | |||
| {"get_array_item", "get"}, | |||
| {"arrays_zip", "zip"}}; | |||
| {"arrays_zip", "zip"}, | |||
| {"logarithm", "log"}}; | |||
There was a problem hiding this comment.
It looks strange in existing Gluten code that this function is not named to "log", which is Spark's function name. Maybe, just corrected here:
https://github.com/apache/incubator-gluten/blob/main/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala#L178
This may also need the change for CH code. @exmy, does it make sense to you?
https://github.com/apache/incubator-gluten/blob/main/cpp-ch/local-engine/Parser/scalar_function_parser/log.cpp#L41
There was a problem hiding this comment.
It's ok for me, and the LOG may need change to ln
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable log function.
How was this patch tested?
UT.