-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Log unknown fallback reason #6237
[Core] Log unknown fallback reason #6237
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Run Gluten Clickhouse CI |
@PHILO-HE I see CH always fail but from the log the build successfully without any error, could you help check ? |
Run Gluten Clickhouse CI |
could you help merge ? @PHILO-HE |
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
This is a small follow up PR to address comment of #4731 (comment)
@zhztheplayer
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)