Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Log unknown fallback reason #6237

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

This is a small follow up PR to address comment of #4731 (comment)

@zhztheplayer

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

gaoyangxiaozhu commented Jun 26, 2024

@zhztheplayer / @PHILO-HE / @rui-mo

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE I see CH always fail but from the log the build successfully without any error, could you help check ?

@gaoyangxiaozhu
Copy link
Contributor Author

@PHILO-HE I see CH always fail but from the log the build successfully without any error, could you help check ?

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

could you help merge ? @PHILO-HE

@PHILO-HE PHILO-HE changed the title [Core] Let's log for unkown fallback reason [Core] Log unknown fallback reason Jun 27, 2024
@PHILO-HE PHILO-HE merged commit eaace6c into apache:main Jun 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants