[GLUTEN-6279][CH] Inroduce JNI safe array #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
7 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/safe_array
branch
from
02d0531 to
beda176
Compare
|
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/safe_array
branch
from
beda176 to
182f9bb
Compare
|
Run Gluten Clickhouse CI |
baibaichen
force-pushed
the
feature/safe_array
branch
from
182f9bb to
18ff9a7
Compare
|
Run Gluten Clickhouse CI |
|
LGTM |
exmy
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To fix memory leak, I Inroduce JNI safe array to avoid call
ReleaseByteArrayElementsmanually(Fixes: #6279)
How was this patch tested?
Using existed UTs