Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6285][VL] Add debian10 vcpkg depends #6286

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

wenwj0
Copy link
Contributor

@wenwj0 wenwj0 commented Jun 30, 2024

What changes were proposed in this pull request?

Add debian 10 support in vcpkg depends.

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)
#6285

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

#6285

@PHILO-HE PHILO-HE changed the title [GLUTEN-6285]Add debian10 vcpkg depends [GLUTEN-6285][VL] Add debian10 vcpkg depends Jul 1, 2024
@FelixYBW
Copy link
Contributor

FelixYBW commented Jul 1, 2024

We don't have CI to track this. Would you like to maintain this support?

@wenwj0
Copy link
Contributor Author

wenwj0 commented Jul 2, 2024

We don't have CI to track this. Would you like to maintain this support?

@FelixYBW Sure, I am willing to do this, please let me know what I need to do.

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jul 4, 2024

@wenwj0, this patch has been verified on debian 10, right?

@wenwj0 wenwj0 force-pushed the support-debian10 branch from 39987d1 to 958c22e Compare July 4, 2024 12:09
@wenwj0
Copy link
Contributor Author

wenwj0 commented Jul 4, 2024

@PHILO-HE Yes, I have successfully verified this on Debian 10 docker, and deployed it on my cluster.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jul 5, 2024

@wenwj0, please rebase the code. Will merge this patch if no CI failure. Thanks!

@wenwj0 wenwj0 force-pushed the support-debian10 branch from 958c22e to 3e3e049 Compare July 5, 2024 06:33
@wenwj0 wenwj0 force-pushed the support-debian10 branch from 3e3e049 to f090509 Compare July 5, 2024 13:45
@PHILO-HE PHILO-HE merged commit 97d0f18 into apache:main Jul 8, 2024
39 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_07_08_2024_time.csv log/native_master_07_07_2024_0cb2db3b7_time.csv difference percentage
q1 34.69 35.76 1.067 103.08%
q2 23.85 23.16 -0.682 97.14%
q3 38.33 41.25 2.927 107.64%
q4 31.32 32.52 1.202 103.84%
q5 68.03 70.16 2.132 103.13%
q6 7.70 11.02 3.323 143.15%
q7 80.37 79.64 -0.728 99.09%
q8 84.50 86.29 1.782 102.11%
q9 124.34 121.32 -3.021 97.57%
q10 48.36 47.36 -1.003 97.93%
q11 20.16 19.77 -0.388 98.07%
q12 28.04 24.54 -3.505 87.50%
q13 37.95 41.42 3.470 109.14%
q14 20.41 18.15 -2.256 88.94%
q15 29.61 33.66 4.048 113.67%
q16 14.78 14.56 -0.221 98.50%
q17 101.16 103.05 1.891 101.87%
q18 147.36 144.75 -2.608 98.23%
q19 13.95 14.82 0.875 106.27%
q20 30.49 31.94 1.450 104.76%
q21 263.82 261.73 -2.087 99.21%
q22 12.64 11.99 -0.655 94.82%
total 1261.86 1268.88 7.013 100.56%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants