[VL] Validate unsupported rewrite string in Re2 #6312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
kecookier
changed the title
FelixYBW
changed the title
kecookier
changed the title
kecookier
force-pushed
the
wip-fix-regexp_replace
branch
from
9128a2a to
642ed1d
Compare
|
@GlutenPerfBot benchmark |
|
ACK, will benchmark TPCH/DS on this pull request |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
kecookier
force-pushed
the
wip-fix-regexp_replace
branch
from
642ed1d to
e447192
Compare
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
PHILO-HE
reviewed
Jul 4, 2024
| const auto& rewriteArg = scalarFunction.arguments()[2].value(); | ||
| if (!rewriteArg.has_literal() || !rewriteArg.literal().has_string()) { | ||
| LOG_VALIDATION_MSG("Rewrite is not string literal for " + name); | ||
| return false; |
There was a problem hiding this comment.
This check will make this function always fall back if non-constant replacement string is used.
Please check whether this comment makes sense: #6224 (comment).
There was a problem hiding this comment.
Thank you for the explanation. I will modify the code according to your suggestions.
There was a problem hiding this comment.
@kecookier, if the proposal is feasible, you can file a drafted pr in velox to see whether the community accepts that. Thanks!
|
ACK, will benchmark TPCH/DS on this pull request |
1 similar comment
|
ACK, will benchmark TPCH/DS on this pull request |
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
|
ACK, will benchmark TPCH/DS on this pull request |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now we only validate the regex pattern, but we also need to validate the rewrite string. The
regexp_functionwill callRE2::GlobalReplace(), which will swallow the errors thrown byRE2::Rewrite().When RE2::CheckRewriteString() fails, Gluten will fallback to vanilla and print a log like:
(Fixes: #6224)
How was this patch tested?
Exist CI.