Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] #6942 breaks shared lib loader #7241

Closed
Yohahaha opened this issue Sep 14, 2024 · 9 comments · Fixed by #7245
Closed

[VL] #6942 breaks shared lib loader #7241

Yohahaha opened this issue Sep 14, 2024 · 9 comments · Fixed by #7245
Labels

Comments

@Yohahaha
Copy link
Contributor

Problem description

#6942 use System.mapLibraryName(libName) to get lib name, which will convert libboost_atomic.so.1.84.0 to libboost_atomic.so.1.84.0.so, it's wrong.

image

System information

n/a

CMake log

No response

@Yohahaha
Copy link
Contributor Author

Caused by: java.io.FileNotFoundException: liblibboost_atomic.so.1.84.0.so
	at org.apache.gluten.jni.JniLibLoader.moveToWorkDir(JniLibLoader.java:206)
	at org.apache.gluten.jni.JniLibLoader.loadAndCreateLink(JniLibLoader.java:184)
	... 42 more

@Yohahaha
Copy link
Contributor Author

@PHILO-HE @zhouyuan could we keep one CI for dynamic lib packing ?

@zhztheplayer
Copy link
Member

Would someone like to fix this first ? Seems to be a minor one. cc @wForget

@Yohahaha
Copy link
Contributor Author

Would someone like to fix this first ? Seems to be a minor one. cc @wForget

I will fix this issue later.

@wForget
Copy link
Member

wForget commented Sep 14, 2024

#6942 use System.mapLibraryName(libName) to get lib name

Is this the root cause? The previous behavior also seemed to use System.mapLibraryName

File file = moveToWorkDir(workDir, System.mapLibraryName(libName));

@wForget
Copy link
Member

wForget commented Sep 14, 2024

Introduced in #6791?

@wForget
Copy link
Member

wForget commented Sep 14, 2024

System.mapLibraryName does result in an incorrect libname, we can remove it in SharedLibraryLoader

image

@wForget
Copy link
Member

wForget commented Sep 14, 2024

@PHILO-HE @zhouyuan could we keep one CI for dynamic lib packing ?

How about adding a run TPC-H / TPC-DS step to velox_weekly.yml?

@zhouyuan
Copy link
Contributor

@Yohahaha @wForget
This is the annoying issue I mentioned to you before, we need to carefully maintain those codes, with different platforms.
Yes, the CentOS 8 based tests is still using dynamic packaging method, the gap is there's not TPCH/DS test on it. Using gluten-it should be able to add the tests quickly. Let me try to add one for this

thanks, -yuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants