From 858a40479805b62130320020596e0769de5a13ca Mon Sep 17 00:00:00 2001 From: lgbo-ustc Date: Mon, 12 Aug 2024 09:24:15 +0800 Subject: [PATCH] enable percent_rank again --- .../org/apache/gluten/backendsapi/clickhouse/CHBackend.scala | 3 ++- .../tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala index 265750c2c78c..06fe8c34ca4a 100644 --- a/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala +++ b/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala @@ -307,7 +307,8 @@ object CHBackendSettings extends BackendSettingsApi with Logging { } wExpression.windowFunction match { - case _: RowNumber | _: AggregateExpression | _: Rank | _: DenseRank | _: NTile => + case _: RowNumber | _: AggregateExpression | _: Rank | _: DenseRank | _: PercentRank | + _: NTile => allSupported = allSupported case l: Lag => checkLagOrLead(l.third) diff --git a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala index 912a5c95de63..0efc1414ce33 100644 --- a/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala +++ b/backends-clickhouse/src/test/scala/org/apache/gluten/execution/tpch/GlutenClickHouseTPCHSaltNullParquetSuite.scala @@ -978,7 +978,7 @@ class GlutenClickHouseTPCHSaltNullParquetSuite extends GlutenClickHouseTPCHAbstr compareResultsAgainstVanillaSpark(sql, true, { _ => }) } - ignore("window percent_rank") { + test("window percent_rank") { val sql = """ |select n_regionkey, n_nationkey,