[GLUTEN-6923][CH] total_bytes_written is not updated in celeborn partition writers
#6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
能加 UT 吗？ |
这要用到celeborn，现在没有集成测试，加不了吧 |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
2 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
exmy
reviewed
Aug 20, 2024
...-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHSparkPlanExecApi.scala
Outdated
Show resolved
Hide resolved
lgbo-ustc
force-pushed
the
6923_1
branch
2 times, most recently
from
9f8c622 to
2cd649e
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
4 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
6923_1
branch
2 times, most recently
from
9fd6642 to
0f41120
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse C |
|
Run Gluten Clickhouse CI |
liuneng1994
reviewed
Aug 21, 2024
...-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHSparkPlanExecApi.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse C |
|
Run Gluten Clickhouse CI |
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…rtition writers (apache#6939) What changes were proposed in this pull request? (Please fill in changes proposed in this fix) Fixes: apache#6923 AQE has dependency on shuffle written bytes to generate a proper plan. How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) manual tests (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #6923
AQE has dependency on shuffle written bytes to generate a proper plan.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
manual tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)