Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7180][CH] Fix ut Eliminate NAAJ when BuildSide is HashedRelationWithAllNullKeys for the CH backend when the aqe is on #7181

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

zzcclp
Copy link
Contributor

@zzcclp zzcclp commented Sep 10, 2024

What changes were proposed in this pull request?

Fix ut Eliminate NAAJ when BuildSide is HashedRelationWithAllNullKeys for the CH backend when the aqe is on

Close #7180.
(Fixes: #7180)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@zzcclp zzcclp requested a review from baibaichen September 10, 2024 08:00
@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE labels Sep 10, 2024
Copy link

#7180

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@PHILO-HE
Copy link
Contributor

@zzcclp, we have a pr to fix the velox CI failure: #7182.

@zzcclp
Copy link
Contributor Author

zzcclp commented Sep 10, 2024

@zzcclp, we have a pr to fix the velox CI failure: #7182.

OK, thanks. let it run the CH ci first, I will rebase the latest main after #7182 merged.

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

…tionWithAllNullKeys` for the CH backend when the aqe is on

Fix ut Eliminate NAAJ when BuildSide is HashedRelationWithAllNullKeys for the CH backend when the aqe is on

Close apache#7180.
Copy link

Run Gluten Clickhouse CI

@zzcclp
Copy link
Contributor Author

zzcclp commented Sep 11, 2024

@zzcclp, we have a pr to fix the velox CI failure: #7182.

already rebased, it passed.

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgbo-ustc
Copy link
Contributor

LGTM

@zzcclp zzcclp merged commit b83bab9 into apache:main Sep 11, 2024
46 checks passed
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
…tionWithAllNullKeys` for the CH backend when the aqe is on (apache#7181)

Fix ut Eliminate NAAJ when BuildSide is HashedRelationWithAllNullKeys for the CH backend when the aqe is on

Close apache#7180.
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…tionWithAllNullKeys` for the CH backend when the aqe is on (apache#7181)

Fix ut Eliminate NAAJ when BuildSide is HashedRelationWithAllNullKeys for the CH backend when the aqe is on

Close apache#7180.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core
Projects
None yet
4 participants