Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7208][VL]fix: loading libvelox.so failed when using static glog #7209

Merged
merged 3 commits into from
Sep 13, 2024
+5 −7
Merged

[GLUTEN-7208][VL]fix: loading libvelox.so failed when using static glog #7209

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
649b3de
fix loading libvelox.so failed when using static glog
JinHelin404 Sep 12, 2024
fb6a833
fix to always hide symbol
JinHelin404 Sep 12, 2024
2544b2a
fix checkstyle
JinHelin404 Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cpp/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,11 @@ file(MAKE_DIRECTORY ${root_directory}/releases)
add_library(gluten SHARED ${SPARK_COLUMNAR_PLUGIN_SRCS})
add_dependencies(gluten jni_proto)

if(ENABLE_GLUTEN_VCPKG)
# Hide symbols of some static dependencies. Otherwise, if such dependencies
# are already statically linked to libvelox.so, a runtime error will be
# reported: xxx is being linked both statically and dynamically.
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
endif()
# Hide symbols of some static dependencies. Otherwise, if such dependencies are
# already statically linked to libvelox.so, a runtime error will be reported:
# xxx is being linked both statically and dynamically.
target_link_options(
gluten PRIVATE -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)

if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
execute_process(
Expand Down
Loading